astoff / devdocs.el

Emacs viewer for DevDocs
297 stars 17 forks source link

[Question] `devdocs-goto-target` seems like `(goto-char 2)`? #4

Closed condy0919 closed 3 years ago

condy0919 commented 3 years ago

The docstring says it will go to the original position. What's the original position meaning?

astoff commented 3 years ago

When you select an entry in devdocs-lookup, you are supposed to be taken to the location of the entry, not to character 2. That's what that command does.

For which entries of which document do you observe this?

condy0919 commented 3 years ago

I'm adding evil integration https://github.com/emacs-evil/evil-collection/commit/86b02f84a8df0ddd6216cb85d49bedd6ee2ab747

I'm curious about that so.

astoff commented 3 years ago

But do you still think there's a bug with .?

FYI, I'm not so happy with devdocs-next/previous-entry, I may replace these commands with devdocs-next/previous-page at some point.

condy0919 commented 3 years ago

But do you still think there's a bug with .?

Maybe a video is more expressive than text.

https://user-images.githubusercontent.com/4024656/121246315-a1044b80-c8d3-11eb-8c2c-31282696e5a3.mp4

FYI, I'm not so happy with devdocs-next/previous-entry, I may replace these commands with devdocs-next/previous-page at some point.

Thanks, I will keep evil-collection update with it.

astoff commented 3 years ago

Okay, I'll check why one lands at the second character rather than the beginning of the line. Otherwise the command is doing what it should. In these examples, you choose entries located at the top of some page, but this is not always the case.

KSSysLab commented 3 years ago

Is it true that there is only one entry in most pages?

astoff commented 3 years ago

No, that's not what I observe. Some documents (e.g., Lua) have one single page.

KSSysLab commented 3 years ago

Finally I realize the usage of devdocs-goto-target.

Would you mind to mention this in the README? I think people will have the same confusion.

astoff commented 3 years ago

I'll expand the Readme eventually.