search

astorije / chai-immutable

Chai assertions for Facebook's Immutable library for JavaScript collections
MIT License
159 stars 16 forks source link

include uses isSuperset #177

Closed dmonego closed 6 years ago

dmonego commented 6 years ago

Include now allows immutable subsets as a valid input, making the behavior more like chai's behavior with objects.

References this issue: https://github.com/astorije/chai-immutable/issues/82

astorije commented 6 years ago

Thanks @dmonego, that's great stuff! Do you think you could update the README and the block above the function you modified to add an example (same in both)?

astorije commented 6 years ago

@dmonego, do you think it would make it clearer to the user if there was an example for your change in the README? It would certainly seem clearer to me 😅

dmonego commented 6 years ago

Thanks for the review! I've posted a changed version of README.md

astorije commented 6 years ago

I'm not 100% ready to release v2.0.0 so I'm going to release this PR under v2.0.0-rc.3 so you can use it without having to wait.

If somehow you want to give more love to this project, feel free to look at other open PRs / issues, I am having a bit of difficulty giving enough time to this project :) Thanks again for your help!

astorije commented 6 years ago

I'm going to release this PR under v2.0.0-rc.3 so you can use it without having to wait.

Done!

dmonego commented 6 years ago

Thank you for the cleanup!

This library has been a great help in cleaning up a lot of tests, and I'd be glad to help out. Are there any issues that are blocking v2.0.0 in particular?

astorije commented 5 years ago

Hey @dmonego, sorry for the delay, but I have finally just released v2.0.0 :) Only blocker was the lack of free time. Still open to getting help if you're still interested!