search

astorije / shout

Shout — The self-hosted web IRC client
http://shout-irc.com/
MIT License
1 stars 0 forks source link

Replace object argument with simpler string in session management functions #13

Closed astorije closed 9 years ago

astorije commented 9 years ago

To my knowledge, I don't think we should expose the complex network object if there is no good reason too (also, we'll be happier if we want to unit test these ^^). Do you confirm?

If you are OK with this change, that will impact #8. Let's merge #8 first and I'll rebase this current PR to include the changes. Done.

astorije commented 9 years ago

@JocelynDelalande This PR is ready for your thorough eyes... :-)

JocelynDelalande commented 9 years ago

Thats a :+1: !

astorije commented 9 years ago

\o/