Implement OTR UI side - Githubissues

JocelynDelalande commented 8 years ago

Currently, OTR is working on the fork, except one have to issue commands by hand. (/otr init from the query window).

A next step would be to add icons/buttons to allow a user to start and get the current status of a query. What I'd suggest :

opened grayed lock : no OTR
something with a lock, to be defined : OTR negotiation is running
closed blue lock : OTR session established, secure communication

Following Mailpile's suggestion I'd suggest also a second icon to show the fingerprint verification status. For now, it will alway show a question mark.

These are only suggestions. But having some UI consistency across tools is IMHO a required step towards bringing strong end-to-end communication to every user.

@almet You offered help, do you think you could work on that UI part ?

JocelynDelalande commented 8 years ago

@astorije I think we discussed about that already, icons and stuff. Sadly, I find no trace, maybe it was a bare IRC discussion, buried in lost memories... Any stuff ?

JocelynDelalande commented 8 years ago

Example UI on a mailpile message.

screenshot-

JocelynDelalande commented 8 years ago

Thanks to @BjarniRunar I found the icons/documents from the modernpgp project, pushing towards an UX effort on encryption/signature. Can be great source of inspiration https://github.com/ModernPGP/icons (even if OTR is not GPG, of course...)

almet commented 8 years ago

Hi! That's a pretty exciting way to get started with all this. I unfortunately can't commit time to this for the next month. If this issue is still open in one month, I will be happy to work on it, otherwise, feel free to take it.

JocelynDelalande commented 8 years ago

@almet ok, I will focus first on backend things first and we'll see where we are in one month :)

astorije commented 8 years ago

@JocelynDelalande, there were discussions and "work" (if we can call it that way, considering how early I stopped) around UI for OTR, but it wasn't merged in our otr branch on this very fork. Everything can be found on this compare view: https://github.com/astorije/shout/compare/otr...astorije:astorije/otr.

For the icons I had used here, those are:

\f09c: unlock, #ccc / gray although we might prefer unlock-alt, not sure why I hadn't picked this one since I actually prefer it.
\f023: lock, #50a656 / green
\f05e: ban, #e74c3c/ red
\f110, spinner, #ccc / gray

Text was not displayed near the icons, but in tooltips. I remember I had to fix tooltips in the code, but this is now unnecessary as tooltips have changed a great deal in The Lounge, going from a JS solution to a full-CSS one (see https://github.com/thelounge/lounge/pull/79).

As you can see, your suggestions are fairly close to what we had started, good :-)

A few things though:

For pending OTR negotiation, you suggest "something with a lock". While I agree with that, we cannot use the stacked icon classes because we use the CSS solution instead of the <i class="fa fa-..." /> solution. So at the moment, I'd vote for going simple and improve later, especially since that icon is not meant to be displayed for more than a few seconds at most. I remember this being our chain of thought when I tried to stack icons last summer, @JocelynDelalande :-)
Secure connection, definitely green lock over blue lock. Your Mailpile example shows that as well, and so do most browsers I believe.
I would not display the fingerprint verification status at all at the moment, until we support it. This will only raise eyebrows on how to get rid of that question mark, which would be impossible. Plus it would not be the first time we say no to a UI element that predict something in the future.

Anyway, exciting! :-)

astorije commented 7 years ago

@almet, would you like to help on this issue? I 100% dropped it because 1) all efforts have been moved to https://github.com/thelounge/lounge, 2) I picked up on hundreds of other issues over this one, sadly.

I don't think @JocelynDelalande is anywhere close to this project either, but I would love to find ways to bring him back :)

JocelynDelalande commented 7 years ago

I don't think @JocelynDelalande is anywhere close to this project either, but I would love to find ways to bring him back :)

So I do… but being resonable, I don't think that will happen any time soon… And from discussion I had with @almet, I guess he won't have time neither. So, that's an open position ;-) for a required feature !

almet commented 7 years ago

I confirm that I won't invest time here! I would love to see this happen, though :)

astorije / shout

Implement OTR UI side #16