search

astorm / MagentoTarToConnect

A small shell script to automatically package tar archives into Magento's Connect 2.0 format.
80 stars 24 forks source link

Add new construct 'additional_authors' #19

Closed MXWest closed 10 years ago

MXWest commented 10 years ago
astorm commented 10 years ago

Thanks for this -- could you do a pull from master, fix any conflicts, and resubmit?

rgabruel commented 10 years ago

@MXWest, can you close this pull request. I open one that fix both the bug in PHP 5.3 and also add the additional authors in both the package.xml file and also the extension XML file under var/connect/module_extension.xml.

astorm commented 10 years ago

Took care of this in a different pull request -- checkout master and if there's anything else your request did that the new one doesn't, let us know.

Appreciate the kick in the pants! :)

MXWest commented 10 years ago

Will do … as for the other pull request My colleague gets in hours before I do ;) …

MIKE WEST Sr. Specialist, Software Development 610 205 3469 micwest@ebay.com

[Description: logo-email.gif]

The information contained in this electronic mail transmission is intended only for the use of the individual or entity named in this transmission. If you are not the intended recipient of this transmission, you are hereby notified that any disclosure, copying or distribution of the contents of this transmission is strictly prohibited and that you should delete the contents of this transmission from your system immediately. Any comments or statements contained in this transmission do not necessarily reflect the views or position of eBay Enterprise, or its subsidiaries and/or affiliates.

From: astorm notifications@github.com<mailto:notifications@github.com> Reply-To: astorm/MagentoTarToConnect reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, September 23, 2014 at 11:15 PM To: astorm/MagentoTarToConnect MagentoTarToConnect@noreply.github.com<mailto:MagentoTarToConnect@noreply.github.com> Cc: "West, Mike" micwest@ebay.com<mailto:micwest@ebay.com> Subject: Re: [MagentoTarToConnect] Add new construct 'additional_authors' (#19)

Took care of this in a different pull request -- checkout master and if there's anything else your request did that the new one doesn't, let us know.

Appreciate the kick in the pants! :)

— Reply to this email directly or view it on GitHubhttps://github.com/astorm/MagentoTarToConnect/pull/19#issuecomment-56620097.

astorm commented 10 years ago

Ah ha, I see, It's Good Pull Request/Bad Pull Request, eh? ;)