search

astorm / MagentoTarToConnect

A small shell script to automatically package tar archives into Magento's Connect 2.0 format.
80 stars 24 forks source link

Generate Extension Xml For Connect #9

Closed rgabruel closed 10 years ago

rgabruel commented 10 years ago

Add the ability to generate the extension xml file using the extension name for connect.

astorm commented 10 years ago

I've only glanced at it briefly, but I'm not quite sure I follow what this update does. Could you elaborate?

rgabruel commented 10 years ago

First, I want to say MagentoTarToConnect is a wonderful tool, however, the extension xml file is missing which hinders the ability to re-package the extension and installing the package in Magento connect. This update generate an extension xml file that can be used to install the extension in magento connect. The MagentoTarToConnect script was only generating the package.xml file, however, magento connect requires another xml file with the exact extension name, and with slightly different nodes.

kojiromike commented 10 years ago

Once you create a package with MagentoTarToConnect, you may want to tweak it using the web interface. (For example, you may want to add multiple authors.) This pull request makes it possible to use the contents already built with MagentoTarToConnect, but through the web, by providing the xml file necessary to populate the "Load Local Package" section. screen shot 2014-05-16 at 10 17 03 am

astorm commented 10 years ago

Ah, got it, that makes sense/sounds useful. I'm just in from a road trip, so I'll take a look a look at it this week.

rgabruel commented 10 years ago

I don't believe this error is emanating from the new code in this pull request. It seems to be to emanating from line 106 inside this method create_package_xml which is part of the origin code base.

astorm commented 10 years ago

Derp! Sorry about that. Looks like I didn't vet the last pull request as well as I should have.

Question: The Extension_Name.xml file — does this belong inside the tgz package? Or should it be generated outside? Every extension I've ever built via the admin puts this int var/connect, and does not build it as part of the tgz package file -- but I'm far from an expert here. Is there a reason you had it as part of the tgz?

rgabruel commented 10 years ago

Ah good point, I overlook this. Let me correct it.

astorm commented 10 years ago

Merged into master (I think — GitHub still confuses me). Thanks for your patience and the new feature!