search

astorm / blackboard-soap-client

A PHP client library for Blackboard 9's Soap API
2 stars 4 forks source link

A few bugs (with fixes) #13

Open timcortesi opened 9 years ago

timcortesi commented 9 years ago

In Soap/Parameters/Base.php: $body .= '</ns1:filter>'; should be replaced with: $body .= '</ns1:'.static::NAME.'>'; (We're assuming that we're always closing a filter tag, when in some cases we are closing an 'f' tag or something else. You need to reference static::NAME for this to be correct. Causes Blackboard to not respond properly)

In /Soap/Parameters/CourseMembership/MembershipFilter.php: public $courseIds; should be replaced with: public $courseId; AND 'courseIds'=>$this->courseIds, should be replaced with: 'courseId'=>$this->courseId, (The correct name is courseId without the 's'. Adding the 's' causes blackboard to not respond correctly)

This file: /Soap/Legacy/Coursemembership.php needs to be renamed to: /Soap/Legacy/CourseMembership.php (The capitalization mistake throws errors)

astorm commented 9 years ago

Thank you Tim! Unfortunately, I don't have a working blackboard instance to test any changes against at the moment, although I'd be happy to merge a pull request with the above.

jounisuo commented 9 years ago

To me it would seem that courseIds (with the 's') is correct.

at least on the latest version <xs:complexType name="MembershipFilter"><xs:sequence><xs:element maxOccurs="unbounded" minOccurs="0" name="courseIds" nillable="true" type="xs:string"/> (also: http://library.blackboard.com/ref/8c09eac0-db9b-4c1f-839a-69ce42234bdf/blackboard/ws/coursemembership/MembershipFilter.html)

But thanks a lot for the rest of the fixes!

astorm commented 9 years ago

@jounisuo @timcortesi My memory is of courseIds as well -- although differences between versions would NOT shock me at all.