search

astorm / pestle

A collection of command line scripts for Magento 2 code generation, and a PHP module system for organizing command line scripts.
MIT License
533 stars 101 forks source link

Rename magento2:generate:schema-upgrade? #214

Open astorm opened 7 years ago

astorm commented 7 years ago

The magento2:generate:schema-upgrade command generates both Schema and Data upgrades -- should we change the name to be more reflective of the command's functions?

davidangel commented 7 years ago

I think that's a good idea.

Maybe magento2:generate:migration ? (I'm sure I'm under the influence of how Laravel implements these sorts of changes.)

astorm commented 7 years ago

Good suggestion @davidangel -- although since the system isn't actually called migrations, and the system works in a way that's fundamentally different (in implementation) to other platform's migration systems (list of scripts in date order vs. 100+ modules in unknown order) I don't know if that's the right choice here. I'm going to keep thinking about this one. :)