search

astrada / ocaml-css-parser

A CSS parser written in OCaml
MIT License
31 stars 5 forks source link

Parse error while reading token `DELIM #4

Closed dylanirlbeck closed 4 years ago

dylanirlbeck commented 4 years ago

First of all, thanks for this great tool! I'm using it in an upcoming PPX and so far it's been amazing. I'm very close to releasing my project to the rest of the world 😄

I'm currently getting the following error while parsing a CSS file:

Screen Shot 2020-04-21 at 5 11 42 PM

What I believe is the offending CSS:

.space-y-0 > :not(template) ~ :not(template) {
  --space-y-reverse: 0;
  margin-top: calc(0 * calc(1 - var(--space-y-reverse)));
  margin-bottom: calc(0 * var(--space-y-reverse));
}

Do you have any ideas on what can be done? Thanks in advance!

astrada commented 4 years ago

I think I found the issue: CSS variables start with -- but that wasn't specified in the lexer.

dylanirlbeck commented 4 years ago

Thanks so much!! This solved my issue.

A bit unrelated, but do you have any resources (papers, tutorials, etc.) you can point me to for understand how you built the lexer/parser? I'd love to understand how ocaml-css-parser works at a deeper level, but as someone relatively new to OCaml it's a bit confusing to me.

Thanks so much @astrada!

astrada commented 4 years ago

Any tutorial on lexers and parser generators will give you the basic concepts needed to understand how they work. For OCaml, I started with the related chapter on Real World OCaml that's very good. Then I used the documentation of sedlex and menhir.