search

astral-sh / packse

Python packaging scenarios
Apache License 2.0
99 stars 10 forks source link

Fix packse when compiled #150

Closed notatallshaw closed 6 months ago

notatallshaw commented 6 months ago

Fixes https://github.com/astral-sh/packse/issues/147

First just making a commit to validate the tests fail when packse is compiled.

notatallshaw commented 6 months ago

Hmmm, I think there should be a step which checks packse build works.

notatallshaw commented 6 months ago

Hmmm, I thought this was going to be like ~5 minutes to do, I alas don't have time today to keep investigating.

And it just revealed I don't understand the nuances of poetry install and github actions environments, I don't understand why I can't run the command packse after running poetry install, I tested it locally and it works fine.

zanieb commented 6 months ago

https://github.com/astral-sh/packse/actions/runs/8283596474/job/22667149584 checks that all the builds work