search

astral-sh / ruff-vscode

A Visual Studio Code extension with support for the Ruff linter.
Other
1.06k stars 53 forks source link

Amend `notebook.source` actions on save recommendation #380

Closed blakeNaccarato closed 9 months ago

blakeNaccarato commented 9 months ago

Looks like this line got prefixed with notebook despite the setting targeting non-notebook files. Just a one-line change, so I hope it's alright I didn't raise an issue on it. Fixes what looks like a one-line error introduced in https://github.com/astral-sh/ruff-vscode/pull/379?

blakeNaccarato commented 9 months ago

Also, I was tempted to swap true for "always" in editor.codeActionsOnSave entries and "explicit" in notebook.codeActionsOnSave entries, (see recommendations here and here), but wanted to limit the changeset since true is still technically allowed.

EDIT: I'll raise this as its own issue since it touches more lines.

charliermarsh commented 9 months ago

Oops, thank you!