astral-sh / ruff-vscode

A Visual Studio Code extension with support for the Ruff linter.
Other
1.06k stars 53 forks source link

Include Alpine in target platforms #387

Closed charliermarsh closed 8 months ago

charliermarsh commented 8 months ago

Summary

This PR ensures that we publish VS Code extensions for the alpine-x86 and alpine-arm64 target platforms.

See https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions for details:

The currently available platforms are: win32-x64, win32-arm64, linux-x64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, darwin-x64, darwin-arm64 and web.

Test Plan

Performed a dry run, and verified that Ruff selected the correct musl wheel for x86:

Screenshot 2024-01-15 at 2 43 04 PM

And again for arm:

Screenshot 2024-01-15 at 2 42 56 PM

charliermarsh commented 8 months ago

Looks good to me if it works

That's my attitude too lol

charliermarsh commented 8 months ago

Appears to have worked with a nightly build:

Screenshot 2024-01-15 at 3 49 11 PM