search

astral-sh / ruff-vscode

A Visual Studio Code extension with support for the Ruff linter.
Other
946 stars 45 forks source link

refactor: rearrange where formatting check takes place #445

Closed hamirmahal closed 2 months ago

hamirmahal commented 2 months ago

Summary

This pull request reverts a separate workflow I added in #437 that checks for formatting issues, and then adds that check back in a much cleaner way.

The purpose of this change is to simplify things and improve maintainability.

Test Plan

CI

hamirmahal commented 2 months ago

Without this change

image

With this change

image

charliermarsh commented 2 months ago

Makes sense, thanks.

hamirmahal commented 2 months ago

You're welcome!