search

astral-sh / ruff-vscode

A Visual Studio Code extension with support for the Ruff linter.
Other
945 stars 45 forks source link

Cannot update Ruff extension to v2024.24.0 (`[error] end of central directory record signature not found: CorruptZip: end of central directory record signature not found`) #485

Closed darkred closed 4 weeks ago

darkred commented 1 month ago

The issue is that I cannot update Ruff extension to v2024.24.0 from v2024.22.0. The update procedure never completes. Instead I'm constantly getting:

Error while updating 'Ruff' extension. Please check the log for more details.  Try downloading manually.

which log contains these entries:

2024-06-03 11:12:58.033 [error] CorruptZip: end of central directory record signature not found
    at d.download (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:86:15815)
    at async ie.C (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:121254)
    at async ie.x (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:120943)
    at async ie.h (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:118337)
2024-06-03 11:12:58.050 [error] end of central directory record signature not found: CorruptZip: end of central directory record signature not found
    at d.download (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:86:15815)
    at async ie.C (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:121254)
    at async ie.x (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:120943)
    at async ie.h (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:104:118337)
Here is a screenshot: ![2024-06-03_130450](https://github.com/astral-sh/ruff-vscode/assets/723651/59ae6ce7-564e-49ab-986a-57c18d5288a7)

Using VSCode 1.89.1 x64 on Windows 11.
Probably related issue: https://github.com/astral-sh/ruff-vscode/issues/421

darkred commented 4 weeks ago

Today's version 2024.26.0 updates fine. Thanks for fixing this.

charliermarsh commented 4 weeks ago

I’m glad to hear it! Unfortunately we didn’t change anything which makes me think we might hit this in the future.