Open diceroll123 opened 7 months ago
MithicSpirit
commented
7 months ago Do we know what license the Sourcery documentation is distributed under? There might be legal issues with basing implementations on it if it is sufficiently restrictive. Although, it might be fine regardless due to Google v. Oracle. I am not a lawyer; this is not legal advice.
diceroll123
commented
7 months ago Also not a lawyer, but my intention here is the (surprisingly not the software development methodology of) clean room design.
After all, this issue's a proposal, and I would say nobody has the copyright over an idea of a lint rule, especially if we can't see the source to replicate it.
In any case, I leave it up to the team to decide!
rogelho-junior-byx
commented
3 weeks ago Hello @diceroll123 is this list updated with Ruff 0.7.x new rules? Asking that just to know if we need to check, thanks
diceroll123
commented
3 weeks ago @rogelho-junior-byx I have not once updated the list since making this issue, would like to hear back from Astral folks before anyone spends time on it tbh 🫠
Sourcery is a closed-source, paid program with refactoring/suggestion rules, some of which are covered by existing rules within Ruff.
Since Sourcery is closed-source, the rules would need to be clean room implementations.
Below, I've enumerated all current Sourcery rules with any overlap with Ruff
0.4.1, for Astral's consideration.Note: There is of course the possibility that some unimplemented rules below are equivalent to different unimplemented rules from different libraries, such as Pylint.
I expect that any implementations made would fall under
RUF(if there is no unimplemented alternative from another set of rules)?assign-if-expSIM108)aug-assignPLR6104)avoid-builtin-shadowA001)aware-datetime-for-utcDTZ003implemented but no autofix in Ruff)bin-op-identityboolean-if-exp-identitySIM210)break-or-continue-outside-loopF701)chain-comparesclass-extract-methodclass-method-first-arg-nameN804)collection-builtin-to-comprehensionC400,C401,C402)collection-into-setPLR6201)collection-to-boolF634)compare-via-equalscomprehension-to-generatorC419)convert-any-to-inconvert-to-enumerateSIM113)dataframe-append-to-concatde-morganSIM208)default-getSIM401)default-mutable-argB006)del-comprehensiondict-assign-update-to-uniondict-comprehensiondict-literalC408)do-not-use-bare-exceptE722)dont-import-test-modulesensure-file-closedSIM115)equality-identityPLR0133+PLR0124)extract-duplicate-methodextract-methodflatten-nested-tryflip-comparisonSIM300)for-append-to-extendPERF401)for-index-replacementfor-index-underscoreB004)guardhoist-if-from-ifhoist-loop-from-ifhoist-repeated-if-conditionhoist-similar-statement-from-ifhoist-statement-from-ifhoist-statement-from-loopidentity-comprehensionC416)inline-immediately-returned-variableRET504)inline-immediately-yielded-variableinline-variableinstance-method-first-arg-nameN805)introduce-default-elseinvert-any-allinvert-any-all-bodylast-if-guardRET505)lift-duplicated-conditionallift-return-into-iflist-comprehensionPERF401)list-literalC408)low-code-qualitymax-min-default(similar toSIM108but not quite the same)merge-assign-and-aug-assignmerge-comparisonsPLR1714)merge-dict-assignmerge-duplicate-blocksSIM114)merge-else-if-into-elifPLR5501)merge-except-handlermerge-isinstancePLR1701+SIM101)merge-list-appendFURB113)merge-list-appends-into-extendmerge-list-extendmerge-nested-ifsSIM102)merge-repeated-ifsmerge-set-addmethod_chainingmin-max-identity(partially covered byPLR2004)missing-dict-itemsPLE1141)move-assignmove-assign-in-blockno-conditionals-in-testsno-loop-in-testsnon-equal-comparisonnone-compareE711)or-if-exp-identityFURB110)pandas-avoid-inplacePD002)path-readFURB101)raise-from-previous-errorB904)raise-specific-errorTRY002)reintroduce-elseremove-assert-trueremove-dict-itemsPERF102+SIM118)remove-dict-keysSIM118)remove-duplicate-dict-keyremove-duplicate-set-keyB033)remove-empty-nested-blockremove-none-from-default-getSIM910)remove-pass-bodyremove-pass-elifremove-redundant-booleanremove-redundant-conditionremove-redundant-constructor-in-dict-unionremove-redundant-continueremove-redundant-except-handlerremove-redundant-exceptionremove-redundant-fstringF541)remove-redundant-ifremove-redundant-passremove-redundant-path-existsremove-redundant-slice-indexremove-str-from-fstringRUF010)remove-str-from-printremove-unit-step-from-rangeremove-unnecessary-castremove-unnecessary-elseRET505)remove-unreachable-coderemove-unused-enumerateremove-zero-from-rangePIE808)replace-apply-with-method-callreplace-apply-with-numpy-operationreplace-dict-items-with-valuesPERF102)replace-interpolation-with-fstringUP031)return-or-yield-outside-functionF704+F706)set-comprehensionFURB142)simplify-boolean-comparisonE712)simplify-constant-sumsimplify-dictionary-updatesimplify-divisionsimplify-empty-collection-comparison(partially covered byPLC1901)simplify-fstring-formattingsimplify-generatorsimplify-len-comparisonsimplify-negative-indexsimplify-numeric-comparisonsimplify-single-exception-tupleB013)simplify-str-len-comparisonsimplify-substring-searchskip-sorted-list-constructionsplit-or-ifssquare-identitystr-prefix-suffixsum-comprehensionswap-if-else-branchesswap-if-expressionswap-nested-ifsswap-variableswitchSIM114)ternary-to-if-expressionRUF021)tuple-literalC408)unwrap-iterable-constructionC409)use-anyuse-assigned-variableuse-contextlib-suppressSIM105)use-countuse-datetime-now-not-todayDT002)use-dict-itemsuse-dictionary-unionuse-file-iteratorFURB129)use-fstring-for-concatenationuse-fstring-for-formattingUP032)use-getitem-for-re-match-groupsuse-isnause-itertools-productuse-joinuse-lenuse-named-expressionuse-nextuse-or-for-fallbackuse-string-remove-affixuse_ilocuseless-else-on-loopPLW0120)while-guard-to-conditionwhile-to-foryield-fromUP028)