search

astral-sh / ruff

An extremely fast Python linter and code formatter, written in Rust.
https://docs.astral.sh/ruff
MIT License
28.59k stars 925 forks source link

Remove `--preview` as a required argument for `ruff server` #12053

Closed snowsignal closed 3 days ago

snowsignal commented 4 days ago

Summary

ruff server has reached a point of stabilization, and --preview is no longer required as a flag.

--preview is still supported as a flag, since future features may be need to gated behind it initially.

Test Plan

A simple way to test this is to run ruff server from the command line. No error about a missing --preview argument should be reported.

github-actions[bot] commented 4 days ago

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

demisto/content (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

``` warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`: - 'ignore' -> 'lint.ignore' - 'select' -> 'lint.select' - 'unfixable' -> 'lint.unfixable' - 'per-file-ignores' -> 'lint.per-file-ignores' warning: `PGH001` has been remapped to `S307`. warning: `PGH002` has been remapped to `G010`. warning: `PLR1701` has been remapped to `SIM101`. ruff failed Cause: Selection of deprecated rule `E999` is not allowed when preview is enabled. ```

snowsignal commented 3 days ago

@MichaReiser Thanks for the review! I'll look into addressing the points you brought up.

I would expect that running ruff server --preview would enable all preview features similar to setting preview = true in the settings.

We also have server settings, lint.preview, and format.preview, that control this behavior. We should make it clear that this would override those settings.