astral-sh / ruff

An extremely fast Python linter and code formatter, written in Rust.
https://docs.astral.sh/ruff
MIT License
30.42k stars 997 forks source link

Stabilize `flake8-async` behavior changes #12268

Closed MichaReiser closed 2 weeks ago

MichaReiser commented 1 month ago
augustelalande commented 1 month ago

Add ASYNC109 to this #12236

charliermarsh commented 1 month ago

Nice. Is this done, or are there more?

augustelalande commented 1 month ago

So that last trio exclusive rule in ruff is ASYNC105, however it has also remained trio only in the reference flake8-async plugin.

ASYNC105: missing-await async trio function called without using await. This is only supported with trio functions, but you can get similar functionality with a type-checker.

expanding the rule is dependent on multi-file type checking so I think it can just be left as is for now.

charliermarsh commented 1 month ago

Awesome, thank you @augustelalande!

augustelalande commented 1 month ago

@charliermarsh I don't think you should close this. Currently I updated the rules to match the upstream behavior, but the change is gated behind preview. I think @MichaReiser meant this issue to track the removal of gating which can be released in the 0.6 release (or 0.7 I thought?).

charliermarsh commented 1 month ago

Ah I see, ok, makes sense.