search

astral-sh / ruff

An extremely fast Python linter and code formatter, written in Rust.
https://docs.astral.sh/ruff
MIT License
32.8k stars 1.09k forks source link

Ruff and reviewdog question #8253

Closed eremeevfd closed 1 year ago

eremeevfd commented 1 year ago

Guys, I'd appreciate a little help here, has anybody integrated reviewdog with ruff yet?
Which --output-format value did you use?

Keramblock commented 1 year ago

@VianneyMI I saw you mentioned it here: https://github.com/astral-sh/ruff/discussions/4982#discussioncomment-6140413 could you please share your config?

charliermarsh commented 1 year ago

I'm gonna merge this into #8655 which is an explicit request to support the reviewdog format as a first-class --output-format.

ryaminal commented 1 year ago

Just so I understand, this was marked closed "not planned" because it's been merged with #8655 , not because we aren't going to have ruff + reviewdog support, right?

charliermarsh commented 1 year ago

@ryaminal - That's correct, "Not planned" is confusing because it includes "issue is a duplicate" (if you hover over the description).

ryaminal commented 1 year ago

Ah, it does say "duplicate" but i totally missed that. doh. Thanks for the response.