Open tiangolo opened 12 months ago
zanieb
commented
12 months ago Thanks for the comprehensive suggestion! There's some discussion at https://github.com/astral-sh/ruff/discussions/8137 already too.
I agree with the general sentiment that positional argument use should be limited.
We may have a hard time with the fix, as we don't perform fixes across multiple files yet.
tiangolo
commented
12 months ago Ah! yes, it seems that's related to the same, sorry, I only checked on issues and not on discussions. 😅 Feel free to close this one!
About the fix, get it, maybe just fixing the calls (and not the signature) would already do most of the work. But in any case, even just the rule detecting it would help a lot.
jack-mcivor
commented
8 months ago FWIW I found a couple of additional issues that I think are the same
This is something I like to do and request people do as well, but I haven't seen a linter that implements my (personal) rule.
I'm a bit ashamed of coming just to add a new issue to request a new non-existing rule/fix just because I would want it, but anyway, worth trying. 😅
Description
I try to avoid callables (functions, methods) with more than two positional parameters/arguments.
I told @Kludex about it a while ago, and he built https://github.com/Kludex/kwonly-transformer which is very close to what I want.
There is also https://github.com/vchaptsev/flake8-keyword-arguments which is a bit closer but only implements the rule/error, not the fix.
Specification (?)
Here's the description of what I would like.
It applies both to creating a function/method signature and to calling it.
I tend to be a bit stricter than that, but I would think that's generalizable enough that it could be useful to others. For example, if there's one required parameter and the rest are optional, I would try to allow only the first one to be positional, all the others would be required to be keyword only. The rationale is that normally it's a function that applies to a specific object and has some parameters/modifications for how to apply it.
The reason for 2 parameters and allowing 2 in most places is mainly for the cases when an operation applies to two things, one is in some way the origin/source and the other is the destiny, so it can be considered starting from the first and going to the second (going left to right, the same direction as when writing or reading code).
Maybe that could be a configurable threshold, could be 2, or could be 0 for people who don't want any positional argument... don't know, for me, it would be fine if it was fixed at 2.
Other ideas
It could be stricter and with more rules, with other things like, if all parameters/arguments are optional, they should all be required, but that (and other potential extra rules) is probably more cumbersome and less flexible.
Auto Fix
Of course, it would be great if it could not just show the error but also auto fix it, but not sure how difficult that is, it would change the calls and hopefully also the function signature.