search

astral-sh / rye

a Hassle-Free Python Experience
https://rye.astral.sh
MIT License
13.82k stars 467 forks source link

Bump boostrap ruff to 0.4.4 #1075

Closed davfsa closed 6 months ago

davfsa commented 6 months ago

Noticed ruff was a bit old and was missing a lot of rules, leading to a lot of "unused noqa".

I unfortunately dont have the rust knowledge to improve this, but it would be nice if we could update ruff independently of rye and still run it using rye lint/fmt.

Thanks for this amazing tool! Gave it a shot today and really really enjoyed playing around with it and testing it out. Currently porting some of my projects to use it!

davfsa commented 6 months ago

The last tests failure is insanely weird and I'm not sure if its expected . Ill leave it without change and let someone else have a look at it, because I cant reproduce it locally and I'm not sure what other file it could be talking about (does space.init create a __init__py?)

https://github.com/astral-sh/rye/actions/runs/9054124712/job/24873624010#step:7:206

bluss commented 6 months ago

Yes, space.init looks like it uses regular "rye init" which creates src/packagename/__init__.py already. I think the new output is expected and can just be confirmed then?

davfsa commented 6 months ago

Thanks for the extra pair of eyes. I had a suspicion it had something to do with that, but was not 100% sure. Made the test account for that too

charliermarsh commented 6 months ago

Thanks!