Open davfsa opened 6 months ago
The windows test failures are a bit confusing.
Failure 1: (link)
It seems like uv functions differently in linux/macos and windows. Its reinstalling both workspace members even tho only one of them changed.
Failure 2: (link) Fixed by https://github.com/astral-sh/rye/pull/1094/commits/decf6f942953c6682bfefd261bc074d35b875a6b
Ordering seems to be different in windows, (not only in that failure, but all through the test results). A #[cfg(unix)]
block would not work here, as there would be too much duplicate code.
The first issue is uv specific, so an update there might be necessary to make it properly consistent
Managed to fix the first failure (https://github.com/astral-sh/rye/pull/1094/commits/decf6f942953c6682bfefd261bc074d35b875a6b) at the expense of a little bit of overhead that comes from the sorting. I am not sure if its worth it to have reproducible tests in all platforms or not.
The second issue is a lot more weird and I find what is determining whether to re-install the project or not in uv. Ill keep investigating
I have no clue how to debug the last failure. I created a Windows 10 VM to run the tests in and was not even able to reproduce the same failures when running the cargo test or when playing around with uv/rye to attempt to reproduce it installing the editable that was not edited
Decided to disable both tests in windows because I have no clue what is going on (cant even reproduce locally). I kept my project ordering change, because it seems like every other pathlike output in rye is sorted too.
EDIT: The last failure looks like not something this PR could have caused. I have seen a similar instance of events like it other prs in this repo, so it might just need a CI rerun Finally a green CI!
I like it. It looks exactly like what I need! When is this PR going to be merged?
This functionality can be enabled by setting
tools.rye.workspace.per_member_lock
totrue
Added a test for the new functionality as well as one for workspaces on its own (as there didn't seem to be any).
Closes #615
This is my first ever rust pr, so any feedback is welcome and appreciated! If anything needs to be changed, "allow edits by maintainers" is on, or post a comment and I'll change the pr accordingly