astral-sh / rye

a Hassle-Free Python Experience
https://rye.astral.sh
MIT License
13.82k stars 467 forks source link

Publish: Allow empty token, so twine uses keyring #1203

Closed emarsden-iso closed 1 month ago

emarsden-iso commented 4 months ago

Similar in spirit to https://github.com/astral-sh/rye/pull/759, but less ambitious.

This just makes rye accept empty-string token values. In such a case, rye just doesn't pass a --password value onto twine. This is valid from twine's perspective; in this case twine will fall back to using its keyring support.

emarsden-iso commented 3 months ago

@charliermarsh @mitsuhiko would you be able to take a look at this when you get a chance? happy to amend the approach as needed