search

astral-sh / uv-pre-commit

Apache License 2.0
49 stars 5 forks source link

At uv-export hook. Closes #16. #18

Closed apollo13 closed 9 hours ago

apollo13 commented 1 week ago

@zanieb This should be ready for review. I tested it locally and it seems to work okay.

apollo13 commented 3 hours ago

Thanks for adjusting the PR @zanieb, sorry for not being fast enough :&

What I dislike about having -e . (ie the project) in the exported requirements.txt is that it is no longer installable by pip by default (I think this is pip default behavior):

ERROR: The editable requirement file:///.../project (from -r requirements.txt (line 2)) cannot be installed when requiring hashes, because there is no single file to hash.

So I still feel like that if we really want to export it with the project by default we should export without hashes.