search

astral-sh / uv

An extremely fast Python package installer and resolver, written in Rust.
https://astral.sh/
Apache License 2.0
15.16k stars 437 forks source link

`install_git_private_https_pat_and_username` breaks git #1980

Open konstin opened 4 months ago

konstin commented 4 months ago

Running install_git_private_https_pat_and_username inserts the user and password for astral-test-user into my keyring:

image

This breaks my git setup because now all invocations in any repository with a github remote try to use the astral-test-user for github:

$ git push
remote: Permission to astral-sh/uv.git denied to astral-test-bot.
fatal: unable to access 'https://github.com/astral-sh/uv/': The requested URL returned error: 403

The test suite should not change a developer's user wide settings, especially if that breaks git.

zanieb commented 4 months ago

This is annoying... sorry.

The solution is probably to create a temporary git config then configure or disable the git credential helper — I don't think we should need one enabled at all this test.

zanieb commented 2 weeks ago

@konstin is this fixed.... or did we just turn the test off?

konstin commented 2 weeks ago

You're right, we only turned the test off