search

astral-sh / uv

An extremely fast Python package and project manager, written in Rust.
https://docs.astral.sh/uv
Apache License 2.0
26.35k stars 766 forks source link

Fork priorization should create a converging transformers resolution #5661

Open konstin opened 3 months ago

konstin commented 3 months ago

When resolving transformers (#5657) in universal mode, we resolve datasets v2.14.4, v2.20.0 and fsspec v2024.5.0, v2024.6.1 while datasets v2.20.0 and fsspec v2024.5.0 would work for both branches in a single converging resolution. We should figure out why that happens and if we can avoid it with smarter fork prioritization (or if it unavoidable with reasonable heuristics and we need to rely on the fork markers serialization for stability in this case).

charliermarsh commented 3 months ago

👍 The only thing I noticed here is that we select that datasets version prior to forking.