Open ayussh-verma opened 5 days ago
charliermarsh
commented
5 days ago That's because we're trying to do a universal resolution. You can instruct the resolve to solve for Windows and non-Windows separately:
[tool.uv]
environments = ["sys_platform == 'win32'", "sys_platform != 'win32'"]
ayussh-verma
commented
5 days ago Thank you for the prompt reply. That unfortunately doesn't work for me: To reproduce:
[project]
name = "test"
version = "0.1.0"
description = "test"
requires-python = ">=3.10"
dependencies = [
"gitlint",
]
[tool.uv]
environments = ["sys_platform == 'win32'", "sys_platform != 'win32'"]uv sync --verbose
I'm not sure why uv is trying to install sh even though that is incompatible with windows. Shouldn't the installation be skipped?
I'm able to run uv add red-discordbot (even without the tool.uv section) which declares a dependency "distro" with the marker sys_platform == 'linux'
uv correctly adds the dependency to the lock file but doesn't install distro
ayussh-verma
commented
5 days ago Just as a sanity check, Poetry is able to install gitlint - poetry add gitlint[core]
❯ poetry run pip list
Package Version
--------------- -----------
arrow 1.2.3
click 8.1.3
colorama 0.4.6
gitlint 0.19.1
gitlint-core 0.19.1
python-dateutil 2.9.0.post0
six 1.16.0Here's the rest of the debug log
DEBUG Selecting: sh==1.14.3 [compatible] (sh-1.14.3.tar.gz)
DEBUG Acquired lock for `C:\Users\X\AppData\Local\uv\cache\sdists-v6\pypi\sh\1.14.3`
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/b7/09/89c28aaf2a49f226fef8587c90c6386bd2cc03a0295bc4ff7fc6ee43c01d/sh-1.14.3.tar.gz
DEBUG No static `pyproject.toml` available for: sh==1.14.3 (MissingPyprojectToml)
DEBUG No static `PKG-INFO` available for: sh==1.14.3 (PkgInfo(UnsupportedMetadataVersion("1.2")))
DEBUG No static `egg-info` available for: sh==1.14.3 (MissingRequiresTxt)
DEBUG Preparing metadata for: sh==1.14.3
DEBUG Ignoring empty directory
DEBUG Resolving build requirements
DEBUG Solving with installed Python version: 3.10.15
DEBUG Solving with target Python version: >=3.10.15
DEBUG Adding direct dependency: setuptools>=40.8.0
DEBUG Found stale response for: https://pypi.org/simple/setuptools/
DEBUG Sending revalidation request for: https://pypi.org/simple/setuptools/
DEBUG Found not-modified response for: https://pypi.org/simple/setuptools/
DEBUG Searching for a compatible version of setuptools (>=40.8.0)
DEBUG Selecting: setuptools==75.3.0 [compatible] (setuptools-75.3.0-py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/90/12/282ee9bce8b58130cb762fbc9beabd531549952cac11fc56add11dcb7ea0/setuptools-75.3.0-py3-none-any.whl.metadata
DEBUG Tried 1 versions: setuptools 1
DEBUG marker environment resolution took 0.089s
DEBUG Installing in setuptools==75.3.0 in C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7
DEBUG Requirement already cached: setuptools==75.3.0
DEBUG Installing build requirement: setuptools==75.3.0
DEBUG Creating PEP 517 build environment
DEBUG Calling `setuptools.build_meta:__legacy__.get_requires_for_build_wheel()`
DEBUG Traceback (most recent call last):
DEBUG File "<string>", line 14, in <module>
DEBUG File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 333, in get_requires_for_build_wheel
DEBUG return self._get_build_requires(config_settings, requirements=[])
DEBUG File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 303, in _get_build_requires
DEBUG self.run_setup()
DEBUG File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 521, in run_setup
DEBUG super().run_setup(setup_script=setup_script)
DEBUG File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 319, in run_setup
DEBUG exec(code, locals())
DEBUG File "<string>", line 5, in <module>
DEBUG File "C:\Users\X\AppData\Local\uv\cache\sdists-v6\pypi\sh\1.14.3\d7QG76cQeuGLPVj9Fw5gY\src\sh.py", line 37, in <module>
DEBUG import fcntl
DEBUG ModuleNotFoundError: No module named 'fcntl'
DEBUG Released lock at `C:\Users\X\AppData\Local\uv\cache\sdists-v6\pypi\sh\1.14.3\.lock`
× Failed to download and build `sh==1.14.3`
╰─▶ Build backend failed to determine requirements with `build_wheel()` (exit code: 1)
[stderr]
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 333, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 303, in _get_build_requires
self.run_setup()
File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 521, in run_setup
super().run_setup(setup_script=setup_script)
File "C:\Users\X\AppData\Local\uv\cache\builds-v0\.tmpRNTII7\lib\site-packages\setuptools\build_meta.py", line 319, in run_setup
exec(code, locals())
File "<string>", line 5, in <module>
File "C:\Users\X\AppData\Local\uv\cache\sdists-v6\pypi\sh\1.14.3\d7QG76cQeuGLPVj9Fw5gY\src\sh.py", line 37, in <module>
import fcntl
ModuleNotFoundError: No module named 'fcntl'Just to clarify: the logs DEBUG Adding transitive dependency for gitlint-core==0.19.1: sh{sys_platform != 'win32'}>=1.14.3, <1.14.3+ do not mean that we're trying to install that package. They mean we're trying to resolve it. So we're trying to resolve sh==1.14.3, which means we need its metadata. That package doesn't include a wheel (see: https://pypi.org/project/sh/1.14.3/#files). So we have to build it. And we're failing to build it for reasons that likely aren't related to uv.
charliermarsh
commented
5 days ago You can probably do environments = ["sys_platform == 'win32'"] if you only want to resolve for Windows.
charliermarsh
commented
5 days ago My guess is that this works on Poetry due to their heuristics that try to detect source distribution metadata? But those are being removed in the next Poetry release IIUC.
charliermarsh
commented
5 days ago I can test it on my Windows machine later though.
ayussh-verma
commented
5 days ago I think you're absolutely right,
The setup file that sh v1.14.3 is using contains import fcntl which is a std-lib module that doesn't exist on Windows
[[package]]
name = "sh"
version = "1.14.3"
description = "Python subprocess replacement"
optional = false
python-versions = "*"
files = [
{file = "sh-1.14.3.tar.gz", hash = "sha256:e4045b6c732d9ce75d571c79f5ac2234edd9ae4f5fa9d59b09705082bdca18c7"},
]This is the lockfile Poetry generated, not sure if it's the heuristics like you mentioned
ayussh-verma
commented
5 days ago I want to resolve for both windows & linux though, thankfully this issue made me stumble upon a more well-maintained commit linter so I'll be parting ways with gitlint... gitlint is using pretty old deps
TL;DR:
uv initfollowed byuv add gitlint==0.19.1fails.pip install gitlint==0.19.1, however, works.uv is trying to install the "sh" dependency from gitlint even though I'm on Windows and the dependency is marked for UNIX only.
DEBUG Adding transitive dependency for gitlint-core==0.19.1: sh{sys_platform != 'win32'}>=1.14.3, <1.14.3+