Session should not timeout when site is actively used

astralapp / astral

Organize Your GitHub Stars With Ease

https://astralapp.com

BSD 3-Clause "New" or "Revised" License

3.22k stars 143 forks source link

Session should not timeout when site is actively used #246

Closed przemoc closed 5 years ago

przemoc commented 5 years ago

I just experienced astral start screen with sign-in button in the middle of editing tags.

syropian commented 5 years ago

Yeah, I got a little lazy with the auth mechanism, where I'm skipping fetching refresh tokens, and just always let the JWT TTL expire, and then force a manual reauthentication. I'm going to be getting Astral updated to Laravel 5.8, which is pretty much just waiting on the jwt-auth package to become compatible, so I'll probably look into this shortly after the upgrade, as it's pretty annoying.

syropian commented 5 years ago

Fixed in #254