search

astralapp / astral

Organize Your GitHub Stars With Ease
https://astralapp.com
BSD 3-Clause "New" or "Revised" License
3.17k stars 141 forks source link

responsive design starting point #366

Closed ppanthony closed 2 years ago

ppanthony commented 2 years ago

I've created an initial sidebar ammend here for the purposes of continuing to create some sort of responsive design for Astral. It's not fully functional with all panes at the moment, but given that I've zero vue and tailwind experience, thought it worth getting eyes on sooner rather than later. What you see here is WIP but a slight improvement on what is there.

syropian commented 2 years ago

Hey @ppanthony

Thanks for your work on this! I'll try and take a closer look this weekend.

Just a heads up that I'm working on a full rewrite on the next branch that is responsive by default, and since most of my time and effort is going into the rewrite, I'm not looking to add additional features to the current version.

However, since you clearly put some good effort in here and because I haven't specifically mentioned the next branch (outside other PRs and issues) I'll see if I can follow through and get this merged soon. For now it might be best to save further contributions for the new version — something I will update the PR template to mention.

Thanks again for your contribution!

ppanthony commented 2 years ago

Hi @syropian - no problem at all, the second commit in this instance, is probably more important than the first, as its a direct bug fix as opposed to a feature. Let me know if you'd prefer me to branch for that commit, and you could potentially close this PR depending. It's likely your next branch is a good bit cleaner if its responsive by default than the code I've created.

syropian commented 2 years ago

Let me know if you'd prefer me to branch for that commit

@ppanthony That would be great, thank you very much! 😄