astrale-sharp / typstfmt

Apache License 2.0
253 stars 25 forks source link

remove header in stdout unless there is a panic #112

Closed ayghri closed 1 year ago

astrale-sharp commented 1 year ago

Hey there! thanks for your issue and PR, so far it seems the PR does nothing? If so could you put it in draft mode so that I know when to review it?

It's A-Okay to add an option for less verbosity, potentially -q --quiet?

Another option that is worth considering is making quiet the default and have a verbose option!

ayghri commented 1 year ago

Hey there! thanks for your issue and PR, so far it seems the PR does nothing? If so could you put it in draft mode so that I know when to review it?

It's A-Okay to add an option for less verbosity, potentially -q --quiet?

Another option that is worth considering is making quiet the default and have a verbose option!

I'll look into it over the weekend. the PR disables the stdout header == input.name == when the formatting doesn't panic.

ayghri commented 1 year ago
astrale-sharp commented 1 year ago

Hi!

is this ready for review? :)

ayghri commented 1 year ago

Hi!

is this ready for review? :)

Yes.

Are there any tests I should run? I've added one bool variable for verbose and one OsString that defaults to "typstfmt.toml"

astrale-sharp commented 1 year ago

Tests run automatically !

astrale-sharp commented 1 year ago

You should git pull since I took the liberty of pushing to your branch in order to resolve merge conflict.

ayghri commented 1 year ago

changes applied!

emilyyyylime commented 1 year ago

Might be worth to just move that header to stderr by default

astrale-sharp commented 1 year ago

I'm going to merge this for now! Thanks a lot ! We can see make these stderr if someone complains or thinks it's a very good idea