Closed ayghri closed 1 year ago
Hey there! thanks for your issue and PR, so far it seems the PR does nothing? If so could you put it in draft mode so that I know when to review it?
It's A-Okay to add an option for less verbosity, potentially
-q --quiet
?Another option that is worth considering is making quiet the default and have a verbose option!
I'll look into it over the weekend. the PR disables the stdout header == input.name ==
when the formatting doesn't panic.
verbose
option so that any println!
is conditioned on verbose
config|c
flag to specify the path to custom toml
file (important for global formatting).Hi!
is this ready for review? :)
Hi!
is this ready for review? :)
Yes.
Are there any tests I should run? I've added one bool variable for verbose and one OsString that defaults to "typstfmt.toml"
Tests run automatically !
You should git pull since I took the liberty of pushing to your branch in order to resolve merge conflict.
changes applied!
Might be worth to just move that header to stderr by default
I'm going to merge this for now! Thanks a lot ! We can see make these stderr if someone complains or thinks it's a very good idea
Hey there! thanks for your issue and PR, so far it seems the PR does nothing? If so could you put it in draft mode so that I know when to review it?
It's A-Okay to add an option for less verbosity, potentially
-q --quiet
?Another option that is worth considering is making quiet the default and have a verbose option!