Closed taooceros closed 1 year ago
@astrale-sharp done
Thanks to these new files I can see the output of your work and it looks really good ! Nice!
You're actually one of the rare person to have edited the formatting code itself and not the tooling, I'm curious, was it difficult?
Most of the examples you chose are quite alike, I think not all of them are necessary although it's not a big deal to leave them as is.
Thanks again for your nice contribution, we're almost good to go!
Could you do it for me since I will be afk for a while? Thanks 😃
I would add a test like this where the linebreak is not there and the formatter adds it.
"$#xx(a,b) &= 1 \ #xx(a,b) &= 1 \$"
and then we would be good to go, thanks for this nice contribution !
I feel like the current implementation won't do it. Maybe I can revise it sometimes. Though maybe some user will prefer to not having a line break unless it is too long? Idk
Just curious, what would be the output of such a test? (It's okay to add the test to verify that it doesn't break or behave weirdly)
Could you do it for me since I will be afk for a while? Thanks 😃
I didn't see that message,
sure! I'll do/test that soon !
Could you do it for me since I will be afk for a while? Thanks 😃
I didn't see that message,
sure! I'll do/test that soon !
no worry I can do it now.
Just curious, what would be the output of such a test? (It's okay to add the test to verify that it doesn't break or behave weirdly)
basically without changing anything.
@astrale-sharp do you think we should add space around &
?
Just curious, what would be the output of such a test? (It's okay to add the test to verify that it doesn't break or behave weirdly)
basically without changing anything.
I'm not sure, it would help to see an example of what you mean!
With the new test, everything looks good and we're covered so I would be keen to merge as is, but If you want to try with spaces around, we can see what it looks like!
One test fails, seems like maybe the snapshot was not registered ?
Ah I made a mistake there. I will fix it tonight
EDIT by @astrale-sharp night is for sleeping
Sorry for the delay. Now it should be good.
No need to apologize! Thanks a lot for this contribution it looks amazing :grin: !
resolve #113
Implement a basic alignment for math block based on the align point. Current rule is:
It scan the syntax twice to retrieve the information (farthest align point). I can't think a way to do it at one pass.
Maybe we can do better for math:
+-/*
) and the align mark&