Closed akhercha closed 3 months ago
@EvolveArt I updated to the most recent stable toolchain (cause of dependencies issues) - what was the reason for the nightly toolchain? I see we use the same toolchain in Madara, was that the reason?
Attention: Patch coverage is 8.72193%
with 1057 lines
in your changes missing coverage. Please review.
Project coverage is 14.02%. Comparing base (
4a6ef2c
) to head (b1ce10e
). Report is 69 commits behind head on main.:exclamation: Current head b1ce10e differs from pull request most recent head d30d796
Please upload reports for the commit d30d796 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@EvolveArt I updated to the most recent stable toolchain (cause of dependencies issues) - what was the reason for the nightly toolchain? I see we use the same toolchain in Madara, was that the reason?
No particular reasons, it's fine to update
Don't merge yet - I'm having a wrong price when dividing the mark price by the spot price of a stablecoin. Checking this
EDIT: I just need to apply the decimals on the median stablecoin price before dividing - doing this asap
EDIT 2: Fixed - just need to remove some unwrap
EDIT 3: Done ✅
Resolves: #48 #61
Added
MODE
environment variable to be able to switch between production/dev,/node/v1/data/subscribe
ws endpoint to be able to subscribe to certain pairs & get median,perp_entries
&future_entries
new tablesChanged
aws-config
&aws-sdk-secretsmanager
8080
to3000
to fix CI test constantly failingStarkex Documentation: https://docs.starkware.co/starkex/perpetual/becoming-an-oracle-provider-for-starkex.html