search

astrand / xclip

Command line interface to the X11 clipboard
GNU General Public License v2.0
1.03k stars 73 forks source link

Default to -filter instead of -silent in a pipeline. #115

Open Janfel opened 3 years ago

Janfel commented 3 years ago

As of xclip 0.13, using xclip in a pipeline requires the user to explicitly add the -filter argument. Changing the default value from -silent to isatty(stdout) ? -silent : -filter would remove this need. The user could then write

foo | xclip | bar
# instead of 
foo | xclip -filter | bar
hackerb9 commented 3 years ago

I agree with this suggestion. Making the most common case the easiest makes sense to me. If a script wants to ensure a specific mode instead of relying on autodetection, it could always specify -in/-out/-filter.

However, the maintainer of xclip is not yet convinced that using isatty() a good idea. Feel free to weigh in on #88 if you have any helpful thoughts.