astrandb / weatherlink

Weatherlink for Home Assistant
MIT License
10 stars 1 forks source link

Additional Sensor Data #72

Closed gunmalmg closed 8 months ago

gunmalmg commented 9 months ago

Feature request

Thank you for making a new integration for Weatherlink. The old one worked fine, but the developer haven't responded on requests for quiet some time. And the sensors generated by the integration did not resulted in long-term statistics - just historic data. So applaus to you for bringing this up to date. 👏

But I would like some additional sensors :

In addition to my primary station "Vantage Pro2, Wireless"(ID1) - I also have a "Sensor Suite"(ID2) with an external Temp-sensor attached which measures the sea temperature. Both sensor stations sends data through the WeatherlinkLIVE-gateway.

I hope you could provide data for that ID2 Sea-temp sensor also through the integration.

Regards/Hälsningar Gunnar Malmgård

Skjermbilde 2023-12-16 kl  21 33 12 Skjermbilde 2023-12-16 kl  21 33 46

What version of the integration are you using?

v0.9.4

Anything in the logs that might be useful for us?

No response

Additional information

No response

astrandb commented 9 months ago

The three sensors are easy to add. However, to add data from an additional sensor suite I need help with collecting data. The easiest way is if you could share your station with me. I hope the shared data is enough, Weathelink removes all "sensitive" data in the shared data stream. You find the sharing function close to the upper right corner of the front bulletin screen. My username is astrandb on weatherlink also.

gunmalmg commented 9 months ago

Now I have shared the station with you.

astrandb commented 9 months ago

Thank you, Now the outdoor data from your station appears in my account. However, the sensor suite temperature is reported as Null. This can be related to filtering when sharing the station. By the way there are old rain_storm data from May 2021 in the sensor suite?! I will prepare a version of the integration according the documentation that you can test with your login. If the sea temterature is appearing everything is good, Otherwise I shall ask developer support at Davis Weatherlink. They are usually very responsive and helpful. I'll be back...

PS The Sea temperature is also missing on the web page so it is probably a permissions issue - if it is OK with your login?? image

astrandb commented 8 months ago

There is now a beta release (v0.9.5b1) available for test. You can download it by selecting redownload in the hacs/weatherlink page. Remember to enable "Show beta versions". Then download and restart HA. I need to think a little more how to display data from secondary devices like your sensor suite with sea temperature. Awaiting another rainy day... All feedback is appreciated. You could help me by making a diagnostic download from the weatherlink device overview page. Then drag the file into this issue thread. I can then see how your external sensor is represented from your end.

astrandb commented 8 months ago

Hi @gunmalmg Regarding sensors connected to a sensor suite: I have taken a deep dive into the documentation and done some testing. It is absolute possible to display your sea-water temperature but I would like to make a universal solution. The aim is to support 0-8 sensor suites and 0-8 leaf/soil sensors that are connected to Live and console devices and display them in a logical way in HA. I have an idea how to acheive that but it will take some time and concentration. I will have to refactor the way detection of devices and sensors are done today.

To just support one device is doable but the effort is wasted when going for the ultimate solution.

I hope you can wait. The integration is a hobby project so I can't promise a delivery date. In the mean time I can make a release of the beta version mentioned above.

gunmalmg commented 8 months ago

Hi

Thank you for your swift response.

Regarding missing sea-temp readings: The ekstra sensor station is online, but I have taken it indoors, due to stormy winter season (I have got 2 stations broken earlier) . The station is online but the temp-sensor is detached - so no readings there now. So there is no wrong with your permissions :-) I have attached a DATA EXPORT for all data from 4.juli.2023. Hope that's what you were asking for regarding diagnostics.

I have installed the beta, and I now get the THSW, The Wind direction in deg, and Solar radiation . But I don't see any sea-temp-sensor Skjermbilde 2023-12-18 kl  15 00 59

I Understand that you would develop a universal solution for the option to add extra sensor stations . And I understand that this is just a hobby and that this could take som time. If I get a beta that reads my sea-temp I will be happy for the time beeing. But there is no rush - since I have disabled the sea-sensor for the winter season.

I appreciate your work and effort.

gunmalmg commented 8 months ago

Lille_Lyngholmen_LIVE_4-7-23_00-00_1_Day_1702906979_v2 (1).csv

astrandb commented 8 months ago

Thanks, That explains the unavailable sea temp sensor. I will prepare a proper release for the added sensors within a few days so that everybody can enjoy them. I just need to filter out solar related sensors from Vue stations.

Sensors attached to extra sensor transmitters will have to wait until the new sensor discovery logic is in place. It will most likely be a breaking change. The users will have to uninstall/reinstall the integration to get rid of stale entities and devices in HA. Hopefully it will be a one-time-only exercise.

astrandb commented 8 months ago

Hi Gunnar I have prepared a new beta release v0.9.6b1 that handles extra sensor suites.

Please give it a try and report back if you find any issues. The sea temperature sensor displays Unknown as explained above but I think it will work when the probe is connected.

I have managed to avoid to break any old configurations (I hope).

gunmalmg commented 8 months ago

Hi Åke

Thank you for the new beta. It seems to work perfectly. The Sensorsuite ID2 is showing up as a new Device. We have to wait until I got to connect the sea-sensor again. Hopefully just over new year. Its on at cottage. You may look at the ID2-rain Entities. That seems to have values - even though there is not connected any rail sensor to the transmitter.

Skjermbilde 2023-12-21 kl  12 44 16

astrandb commented 8 months ago

Fine, then I will prepare a full release. Just a few unrelated minor fixes that should be included.

The API returns null for most uninstalled sensors and null is displayed as Unknown. The rain sensors return 0 so there is no way for the integration to distinguish uninstalled from no rain. There is a rain-storm recorded in the API beginning 23 may 2021 03:15:00, ending 24 may 2021 07:01:01, 2,0 mm in total.

I would rather not let the integration disable the not-installed sensors because then a complete re-install of the integration is needed to enable them if a user plugs in a new probe. Now it is enough to reload the integration from the GUI or restart HA.

If you dont want to see the stale sensors you can disable them manually in the entity dialog/cog-wheel tab.

gunmalmg commented 8 months ago

Thank you for your work. Excellent. And good explanations.

I come back to you when the sea-sensor is back.

In the meanwhile : God jul och gott nytt år 🎄

astrandb commented 8 months ago

Fixed in v0.9.6