astriaorg / astria

A monorepo containing all the custom components of the Astria network, a decentralized system that replaces traditional sequencers, offering a shared, permissionless sequencer network.
https://www.astria.org/
Apache License 2.0
116 stars 75 forks source link

sequencer: rename `sourceActionIndex` to `positionInTransaction` #1735

Open ethanoroshiba opened 3 weeks ago

ethanoroshiba commented 3 weeks ago

We should rename all instances of source_action_index to position_in_transaction to be clearer about what this field means.

┆Issue Number: ENG-950

SuperFluffy commented 3 weeks ago

Is this still an open issue? I believe you closed it with #1718?

ethanoroshiba commented 3 weeks ago

Is this still an open issue? I believe you closed it with #1718?

@SuperFluffy there are many instances of source_action_index that I think should still be changed to match, though I realize the issue said sourceActionIndex before. I've adjusted the description accordingly.