Zeroize and don't reveal private keys

astriaorg / astria

A monorepo containing all the custom components of the Astria network, a decentralized system that replaces traditional sequencers, offering a shared, permissionless sequencer network.

https://www.astria.org/

Apache License 2.0

111 stars 73 forks source link

Zeroize and don't reveal private keys #594

Open SuperFluffy opened 9 months ago

SuperFluffy commented 9 months ago

astria-cli does not treat private keys with sufficient care and secrecy. It should

zeroize private keys before dropping them
refrain from printing as plain text private keys to stdout/stderr or as part of debug messages
not read private keys from stdin as plain text

SuperFluffy commented 3 months ago

https://github.com/astriaorg/astria/pull/1111 provides refinement types that avoid leaking the private key altogether.

The last place leaking the private key is found in https://github.com/astriaorg/astria/blob/5387149274df37a382a21ccf0e431c73deee0c42/crates/astria-cli/src/commands/sequencer.rs#L61. Once this is resolved this issue can be closed.