search

astro-datalab / datalab

Python client to interface with the NSF NOIRLab's Astro Data Lab Science Platform.
MIT License
22 stars 8 forks source link

bug striping result set to one character #65

Closed iglesu closed 1 year ago

iglesu commented 1 year ago

This bug was introduced in 99f72b4bf4b5bc207ffd28498f8dcd5de832a66a For a given result query, it returns r[1].strip(), which makes no sense at all, I think this could have been the result of test line not being cleaned up?

rnikutta commented 1 year ago

That's commit 99f72b4bf4b5bc207ffd28498f8dcd5de832a66a in the querymanager repo. 'Data Lab Admin' made that commit on March 24, 2023. I suppose @mjfitzpatrick used this account? This change would make sense if r was expected to be a sequence (e.g. a list), and r[1] a string in that list. But is r actually a string already? Maybe it is now (due to some change elsewhere), but was a list back in March? Need to (together please) a) track it down, and b) verify that nothing is broken in querymanager now, by reverting to return qcToString(r).

iglesu commented 1 year ago

I think it has always been a string of characters, either in 'text' or byte form, for now I've changed that part back to what was all along. I also have to check the querymanager end as the same original fix has the same thing in another function which is used in querymanager, but I'll look into that more thoroughly on Monday.

On Oct 28, 2023, at 4:50 PM, Robert Nikutta @.***> wrote:

That's commit 99f72b4bf4b5bc207ffd28498f8dcd5de832a66a https://github.com/astro-datalab/querymanager/commit/99f72b4bf4b5bc207ffd28498f8dcd5de832a66a in the querymanager repo. 'Data Lab Admin' made that commit on March 24, 2023. I suppose @mjfitzpatrick https://github.com/mjfitzpatrick used this account? This change would make sense if r was expected to be a sequence (e.g. a list), and r[1] a string in that list. But is r actually a string already? Maybe it is now (due to some change elsewhere), but was a list back in March? Need to (together please) a) track it down, and b) verify that nothing is broken in querymanager now, by reverting to return qcToString(r).

— Reply to this email directly, view it on GitHub https://github.com/astro-datalab/datalab/pull/65#issuecomment-1783944567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABX3HOAPENTSYMBRJCHZVQTYBWK4HAVCNFSM6AAAAAA6UMYIZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHE2DINJWG4. You are receiving this because you authored the thread.