search

astro-datalab / datalab

Python client to interface with the NSF NOIRLab's Astro Data Lab Science Platform.
MIT License
22 stars 8 forks source link

Added step to upload package to PyPI in workflow #66

Closed iglesu closed 11 months ago

iglesu commented 11 months ago

On Friday I made a mistake and pushed to master, 46ff5d77, a modified version of the workflow datalab_pip.yml, basically I added the last step that checks if it is a release, and if so uploads the packages to PyPi.

The push I did on Friday, was pointing to the test.pypi.org. This version simply is pointing to the "real" pypi.org.

iglesu commented 11 months ago

This looks fine. One idea came to mind on this commit that you can include at your discretion, also I had one idea for the previous commit:

  1. Instead of the commented test line we could have one run command and then toggle between the test repository and main repository using a variable. Something like twine upload --verbose --repository-url "${{ env.PYPI_REPO_URL }}" dist/*. This doesn't make a big difference but perhaps would make it easier to use and reduce the chance of accidental publishes.
  2. In the other commit I noticed we are publishing when the release is created which I think will trigger for pre-releases and releases. This might be fine depending on the release strategy but I wanted to throw that out there. There are prereleased and released types available if you want to target one specifically.

Otherwise I think this is all set!

Thank you Chadd! specially for 2)! Did two commits to address your commentary: 1) 0cf9347c87 2) 0ba4d7b07