astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
18 stars 2 forks source link

Fix!: correct impact parameters #108

Closed fjebaker closed 1 year ago

fjebaker commented 1 year ago

Still todo:

fjebaker commented 1 year ago

Cunningham transfer function tests are still failing. These should be inspected before the test values are updated.

codecov-commenter commented 1 year ago

Codecov Report

Merging #108 (8202503) into main (5f039ea) will increase coverage by 1.96%. The diff coverage is 85.55%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   65.70%   67.66%   +1.96%     
==========================================
  Files          53       53              
  Lines        2044     2066      +22     
==========================================
+ Hits         1343     1398      +55     
+ Misses        701      668      -33     
Impacted Files Coverage Δ
src/accretion-geometry/bootstrap.jl 72.72% <ø> (ø)
src/tracing/charts.jl 93.54% <ø> (ø)
src/tracing/utility.jl 68.57% <66.66%> (+10.67%) :arrow_up:
src/metrics/boyer-lindquist-fo.jl 97.43% <89.47%> (-2.57%) :arrow_down:
...ransfer-functions/cunningham-transfer-functions.jl 87.58% <95.00%> (+24.67%) :arrow_up:
src/rendering/rendering.jl 73.07% <100.00%> (+0.52%) :arrow_up:
src/tracing/precision-solvers.jl 73.97% <100.00%> (ø)