search

astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
16 stars 2 forks source link

fix: jacobian calculations with thick discs #169

Closed fjebaker closed 10 months ago

fjebaker commented 10 months ago

It seems that for thick discs a ridiculously high tolerance is needed to correctly evaluate the Jacobian. Added logic that changes the jacobian tolerances within some unstable radius to ensure the transfer functions are still well behaved.

fjebaker commented 10 months ago

Before:

Screenshot 2023-09-11 at 17 27 40

After:

Screenshot 2023-09-11 at 17 27 48
codecov-commenter commented 10 months ago

Codecov Report

Patch coverage: 24.13% and project coverage change: -0.53% :warning:

Comparison is base (b7a11de) 69.31% compared to head (f23ccd7) 68.79%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #169 +/- ## ========================================== - Coverage 69.31% 68.79% -0.53% ========================================== Files 66 66 Lines 2728 2753 +25 ========================================== + Hits 1891 1894 +3 - Misses 837 859 +22 ``` | [Files Changed](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol) | Coverage Δ | | |---|---|---| | [src/tracing/configuration.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYWNpbmcvY29uZmlndXJhdGlvbi5qbA==) | `86.66% <ø> (ø)` | | | [src/transfer-functions/utils.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYW5zZmVyLWZ1bmN0aW9ucy91dGlscy5qbA==) | `53.94% <0.00%> (-21.98%)` | :arrow_down: | | [...ransfer-functions/cunningham-transfer-functions.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYW5zZmVyLWZ1bmN0aW9ucy9jdW5uaW5naGFtLXRyYW5zZmVyLWZ1bmN0aW9ucy5qbA==) | `97.35% <100.00%> (+0.05%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.