Feat: more or less working thick disc transfer functions

[fjebaker]

There are a number of things I am still not really happy about. I'll document them in an issue so that this PR can be merged.

The thick disc transfer functions seem to integrate mostly okay for default parameters with this PR. The main changes were:

• root find again with the thick disc as a visibility criteria
• if geodesic falls within ISCO in jacobian, force the jacobian to diverge and then use that to update the visibility status
• improve scaling error in geometry intersection calculations

[fjebaker]

Two tests failed:

smoke-utility: Test Failed at /home/runner/work/Gradus.jl/Gradus.jl/test/smoke-tests/cunningham-transfer-functions.jl:37
  Expression: ≈(measure_ctf(test_ctf1(0.998, 30, 800.0)), 0.17351504941705492, atol = 1.0e-5)
   Evaluated: 0.1682889574818813 ≈ 0.17351504941705492 (atol=1.0e-5)

 smoke-utility: Test Failed at /home/runner/work/Gradus.jl/Gradus.jl/test/smoke-tests/cunningham-transfer-functions.jl:38
  Expression: ≈(measure_ctf(test_ctf1(0.998, 30, 1000.0)), 0.19085561680308122, atol = 1.0e-5)
   Evaluated: 0.21563413017178515 ≈ 0.19085561680308122 (atol=1.0e-5)

Those are fairly significant differences. They are also the two really large radii tests, so I think I can track this down to being related to the gtol function needing some more tuning.

[fjebaker]

[codecov-commenter]

Codecov Report

Patch coverage: 91.37% and project coverage change: -0.48% :warning:

Comparison is base (ad4db76) 68.98% compared to head (6d3a239) 68.51%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #172 +/- ## ========================================== - Coverage 68.98% 68.51% -0.48% ========================================== Files 66 66 Lines 2770 2779 +9 ========================================== - Hits 1911 1904 -7 - Misses 859 875 +16 ``` | [Files Changed](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol) | Coverage Δ | | |---|---|---| | [src/tracing/tracing.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYWNpbmcvdHJhY2luZy5qbA==) | `90.38% <ø> (ø)` | | | [src/geometry/discs/datum-plane.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL2dlb21ldHJ5L2Rpc2NzL2RhdHVtLXBsYW5lLmps) | `70.00% <66.66%> (-7.78%)` | :arrow_down: | | [src/geometry/discs/thin-disc.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL2dlb21ldHJ5L2Rpc2NzL3RoaW4tZGlzYy5qbA==) | `66.66% <75.00%> (-17.95%)` | :arrow_down: | | [src/geometry/discs.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL2dlb21ldHJ5L2Rpc2NzLmps) | `29.03% <81.81%> (+29.03%)` | :arrow_up: | | [src/tracing/precision-solvers.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYWNpbmcvcHJlY2lzaW9uLXNvbHZlcnMuamw=) | `65.71% <84.00%> (-6.09%)` | :arrow_down: | | [src/redshift.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3JlZHNoaWZ0Lmps) | `96.15% <88.88%> (+0.07%)` | :arrow_up: | | [src/geometry/discs/shakura-sunyaev.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL2dlb21ldHJ5L2Rpc2NzL3NoYWt1cmEtc3VueWFldi5qbA==) | `90.90% <100.00%> (-0.76%)` | :arrow_down: | | [src/geometry/discs/thick-disc.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL2dlb21ldHJ5L2Rpc2NzL3RoaWNrLWRpc2Muamw=) | `66.66% <100.00%> (-13.34%)` | :arrow_down: | | [src/tracing/callbacks.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYWNpbmcvY2FsbGJhY2tzLmps) | `90.47% <100.00%> (+0.47%)` | :arrow_up: | | [...ransfer-functions/cunningham-transfer-functions.jl](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol#diff-c3JjL3RyYW5zZmVyLWZ1bmN0aW9ucy9jdW5uaW5naGFtLXRyYW5zZmVyLWZ1bmN0aW9ucy5qbA==) | `96.77% <100.00%> (-0.56%)` | :arrow_down: | | ... and [2 more](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/astro-group-bristol/Gradus.jl/pull/172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astro-group-bristol)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.