Closed phajy closed 8 months ago
I've modified your solution: I like that we no longer have silent extrapolations happening, but am wary of allowing extrapolations since these can lead to hard-to-debug numerical problems if the extrapolation regime is poor. The alternative fix I've added is that we clamp the interpolation within the extrema of the domain, and print a warning to the user informing them that the point is outside of the domain and they may require additional geodesics to populate that region.
This is equivalent to constant extrapolation, but tells the user it is happening.
I've also made the interpolation functions use the utility _make_interpolation
function, so that if we decide that we want to change the interpolation / extrapolation defaults, this is easier to do!
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
e9e8632
) 68.49% compared to head (9cb90e6
) 68.75%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request adds extrapolation to the orbit-solving interpolation. The
extrapolate=true
argument has been added to theLinearInterpolation
function calls in thePlungingInterpolation
struct.