codecov-commenter
commented
1 year ago Codecov Report
Merging #62 (b5e282c) into main (44d0dcf) will increase coverage by
0.00%. The diff coverage is40.00%.
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 64.99% 65.00%
=======================================
Files 41 41
Lines 1357 1360 +3
=======================================
+ Hits 882 884 +2
- Misses 475 476 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/transfer-functions/integration.jl | 94.38% <ø> (ø) |
|
| src/transfer-functions/precision-solvers.jl | 65.21% <16.66%> (ø) |
|
| ...ransfer-functions/cunningham-transfer-functions.jl | 97.29% <75.00%> (-1.30%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Transfer functions were being incorrectly calculated for large impact parameters -- presumably due to something in the way these are mapped in curve space. Everything seems to be fixed by just scaling the observer position with target emission radius, so that is done here.
Updated test values to reflect improved precision, and now use mean instead of sum as the validation metric, since number of points may change.
Also changed the root finder algorithm to Root's Order0, since this dramatically improves performance.