astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
18 stars 2 forks source link

Feat: Image plane API #67

Closed fjebaker closed 1 year ago

fjebaker commented 1 year ago

Added the ability to easily render grids of impact parameters for use when calculating 2d transfer functions or binning spectra to sample the inner parts of the accretion disc better.

Still to do

Opening draft PR to get codecov to do what I'm too lazy to do locally.

codecov-commenter commented 1 year ago

Codecov Report

Merging #67 (a3ce788) into main (e96cfea) will increase coverage by 0.73%. The diff coverage is 86.30%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   64.87%   65.60%   +0.73%     
==========================================
  Files          41       43       +2     
  Lines        1355     1439      +84     
==========================================
+ Hits          879      944      +65     
- Misses        476      495      +19     
Impacted Files Coverage Δ
src/accretion-geometry/bootstrap.jl 46.66% <ø> (ø)
src/corona-to-disc/flux-calculations.jl 0.00% <0.00%> (ø)
src/tracing/utility.jl 50.00% <ø> (ø)
src/transfer-functions/transfer-functions-2d.jl 0.00% <0.00%> (ø)
src/corona-to-disc/sky-geometry.jl 89.65% <60.00%> (-6.65%) :arrow_down:
src/GradusBase/metric-params.jl 25.00% <75.00%> (+25.00%) :arrow_up:
src/image-planes/planes.jl 94.28% <94.28%> (ø)
src/image-planes/grids.jl 100.00% <100.00%> (ø)
src/line-profiles.jl 100.00% <100.00%> (ø)
src/tracing/callbacks.jl 84.00% <100.00%> (+4.00%) :arrow_up:
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fjebaker commented 1 year ago

Need to consider the best way to do the areas in a generic way, so will open a new PR for that at some point.