astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
18 stars 2 forks source link

Chore!: simple hygiene and renames #69

Closed fjebaker closed 1 year ago

fjebaker commented 1 year ago

Working towards #68, remove the majority of those unused where {T} captures, and renamed a handful of functions to be more descriptive. This includes the names for the different metrics, which should now be consistent and also ommit needing to think about implementation details (the *AD or *FO tails).

Restructured some of the tests and reduced the resolution of the traces to hopefully speed the suite up a little. Added some tests for inference.

codecov-commenter commented 1 year ago

Codecov Report

Merging #69 (2222f41) into main (c381891) will increase coverage by 2.19%. The diff coverage is 52.04%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   65.60%   67.80%   +2.19%     
==========================================
  Files          43       43              
  Lines        1439     1441       +2     
==========================================
+ Hits          944      977      +33     
+ Misses        495      464      -31     
Impacted Files Coverage Δ
src/GradusBase/metric-params.jl 25.00% <0.00%> (ø)
src/GradusBase/physical-quantities.jl 0.00% <0.00%> (ø)
src/accretion-geometry/bootstrap.jl 46.66% <0.00%> (ø)
src/corona-to-disc/corona-models.jl 83.33% <0.00%> (ø)
src/corona-to-disc/flux-calculations.jl 0.00% <ø> (ø)
src/corona-to-disc/sky-geometry.jl 89.65% <0.00%> (ø)
src/image-planes/planes.jl 82.50% <0.00%> (-11.79%) :arrow_down:
src/metrics/kerr-refractive-ad.jl 0.00% <0.00%> (ø)
src/orbits/orbit-interpolations.jl 0.00% <0.00%> (ø)
src/rendering/utility.jl 33.33% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.