astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
18 stars 2 forks source link

Feat: work in progress disc profiles #74

Closed fjebaker closed 1 year ago

fjebaker commented 1 year ago

Cleaned up a number of bugs, including what was discussed in #71 (thread).

Started drafting the disc profiles API so we can use all sorts of fun emissivity profiles for the accretion disc models when calculating e.g. lag transfers or line profiles. This is very early days yet and no new user API is exposed in this PR.

Added more tests and fixed some inference issues.

codecov-commenter commented 1 year ago

Codecov Report

Merging #74 (86d5c15) into main (ec031bb) will increase coverage by 2.66%. The diff coverage is 60.34%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   69.02%   71.69%   +2.66%     
==========================================
  Files          43       44       +1     
  Lines        1485     1512      +27     
==========================================
+ Hits         1025     1084      +59     
+ Misses        460      428      -32     
Impacted Files Coverage Δ
src/point-functions.jl 52.38% <0.00%> (ø)
src/corona-to-disc/disc-profiles.jl 65.46% <50.00%> (+1.18%) :arrow_up:
src/transfer-functions/transfer-functions-2d.jl 67.30% <60.00%> (-16.03%) :arrow_down:
src/line-profiles.jl 78.26% <78.57%> (-21.74%) :arrow_down:
...ransfer-functions/cunningham-transfer-functions.jl 97.33% <100.00%> (ø)
src/transfer-functions/precision-solvers.jl 63.82% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)
src/metrics/johannsen-psaltis-ad.jl 100.00% <0.00%> (+5.55%) :arrow_up:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.