astro-group-bristol / Gradus.jl

Extensible spacetime agnostic general relativistic ray-tracing (GRRT).
https://astro-group-bristol.github.io/Gradus.jl/dev/
GNU General Public License v3.0
18 stars 2 forks source link

Feat: Kerr-Newman metric #94

Closed fjebaker closed 1 year ago

fjebaker commented 1 year ago

The event horizon is not being correctly calculated for this metric yet, suggesting there is a typo somewhere but I can't seem to find it.

There's also the ambiguity between the EH being

$$ \left. \frac{1}{g{rr}}\right \rvert{r_\text{EH}} = 0, $$

or the Killing horizon corresponding to the $\frac{\partial}{\partial t}$ and $\frac{\partial}{\partial \phi}$ Killing vectors, i.e.

$$ \left. \left( g{t\phi}^2 - g{tt} g{\phi \phi} \right) \right\rvert{r_\text{EH}} = 0. $$

They should be the same. For the Kerr-Newman metric currently implemented, they are not when $|a|>0$.. so... that needs to be fixed.

Also missing tests.

fjebaker commented 1 year ago

Found the mistake! Once again, I had a factor $2$ too much in the $g_{t\phi}$ component.

fjebaker commented 1 year ago

From Ghosh & Afrin (2023):

Screenshot 2023-03-03 at 22 07 18

For the case of $Q = 0$ and $Q = 0.6$ with our code:

kerr-kerr-newman-shadows

fjebaker commented 1 year ago

Just to be a bit cheeky, setting the integration domain to terminate further from the event horizon (above figure is to within $1$% of $r\text{g}$ or $\approx 1.0227 r\text{g}$, now setting $20$% of $r\text{g}$ or $\approx 1.215 r\text{g}$):

kerr-example-newman

It's a little bit rounder (~;

Overlaying the closer approximation, since this only affects the left side:

kerr-newman-diff-closeness