search

astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

Branches and CI #104

Closed dpshelio closed 5 years ago

dpshelio commented 6 years ago

I have a question for everyone - I've found out why there's a problem with SOPT/Purify on jenkins. We are building against master but we should building against development So, normally (and that's not a big norm), master is treat as the cutting-edge/development branch (that's why is the default, though in our case it's been development for a while) and say stable as the one from where we do releases. So, I could change jenkins to build against development but it would make more sense to me to change our branching conversion as follows:

  • development rename it as master
  • master rename it as stable
  • Keep jenkins building master as the main build everynigth
  • Create a new build on jenkins which is run stable periodically to see whether we need to fix something on releases (because updates on dependencies) Would the people be happy with this? The only change would be for people to branch from master next feature people want to develop a new thing. I could easily change jenkins.... but because the naming between jenkins and github is not 1:1, it can be a bit confusing.
RolandMacDoland commented 6 years ago

Sounds sensible to me but what would development become ?

Luke-Pratley commented 6 years ago

If I remember right, the point of master at the moment is the push to the BASP repo, which is public. I don't see a problem with renaming it stable.

dpshelio commented 6 years ago

As discussed on slack, this will be done after we make the public release. At the moment jenkins is passing building development :tada:

Luke-Pratley commented 6 years ago

That is really awesome :)))

Luke-Pratley commented 6 years ago

@dpshelio, does jenkins deal with this? https://github.com/astro-informatics/purify/issues/103

dpshelio commented 6 years ago

Nope... only sopt is passing :( - we will have to check what's now wrong with purify...

Luke-Pratley commented 6 years ago

:(

Luke-Pratley commented 5 years ago

@dpshelio This is done right?