Defaults in CMake - Githubissues

astro-informatics / purify

Next-generation radio interferometric imaging.

https://astro-informatics.github.io/purify

GNU General Public License v2.0

17 stars 13 forks source link

Defaults in CMake #110

Closed dpshelio closed 5 years ago

dpshelio commented 6 years ago

Benchmark has been dissabled on #107

ilectra commented 6 years ago

Summarizing the discussion on the values of several defaults:

Large datasets for testing will be removed, and so will the CMake option. - Luke
Benchmark - on/off?
CASA - on/off?

Luke-Pratley commented 6 years ago

Build type should be Release MPI should be off by default OpenMP should be on by default Tests on Benchmarks off Doxygen off CASA off (documentation notification) ArrayFire off

Large dataset to be removed

RolandMacDoland commented 6 years ago

Relates to #143

Luke-Pratley commented 5 years ago

@dpshelio I have noticed an issue related to this! So the version of boost that CMake can detect is tied to the version of CMake. If we want to use boost 1.67, the minimum version of CMake is 3.12.

Luke-Pratley commented 5 years ago

Also, the version of boost that we pull using the cookoff is 1.67. This means, when I used CMake 3.10, it was building boost 1.67, but couldn't import the right modules.