search

astro-informatics / purify

Next-generation radio interferometric imaging.
https://astro-informatics.github.io/purify
GNU General Public License v2.0
17 stars 13 forks source link

Simulation bug fixes #247

Closed Luke-Pratley closed 5 years ago

Luke-Pratley commented 5 years ago

The units for field of view were being scaled when the measurement units were in lambda. But, this is not needed for simulations. Scaling only now happens for real data not simulations.

Sampling pattern range was too big in the simulations causing the PSF to be unrealistic in some cases. pi/3 should be at most pi/4 (pi/6 would also be okay).

codecov-io commented 5 years ago

Codecov Report

Merging #247 into development will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #247   +/-   ##
============================================
  Coverage        86.43%   86.43%           
============================================
  Files               67       67           
  Lines             5309     5309           
============================================
  Hits              4589     4589           
  Misses             720      720

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 419cfc9...0e1f69e. Read the comment docs.

Luke-Pratley commented 5 years ago

@dpshelio Can you approve this?