Closed dpshelio closed 5 years ago
Merging #254 into development will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## development #254 +/- ##
============================================
Coverage 86.44% 86.44%
============================================
Files 67 67
Lines 5310 5310
============================================
Hits 4590 4590
Misses 720 720
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1483be3...973793f. Read the comment docs.
@dpshelio The tests pass, which is a bit strange 😅
@dpshelio Okay it doesn't fail in travis because we set it manually in the CMake here https://travis-ci.com/astro-informatics/purify/jobs/182169901#L397-L411
Phew! Yeah, that makes sense... Then we should also change the Travis version, to don't set up any as it's done inside the cmake files.
This should fail now as 3.0.1 doesn't exist.
This should fail till we release sopt 3.0.1 After releasing we can remove this restriction.